Conversation
PR #453 changed how commands were escaped but did not update the functional tests to match. Two functional tests were failing as a result. This commit fixes those tests.
Strict host key checking causes functional tests to fail if the vagrant SSH server is not yet in the developer's known_hosts file. To avoid this problem, explicitly disable host key checking for functional tests.
Normally Travis CI runs builds twice on PRs, once for the push to the branch, and another for the PR itself. This is redundant and causes PRs checks to take longer that necessary. Fix this by restricting "push" builds to the master branch only.
mattbrictson
commented
Jul 1, 2019
| end | ||
| a_host.ssh_options = verify_host_opt | ||
| keepalive_opt = { keepalive: true } | ||
| test_host = a_host.dup |
Member
Author
There was a problem hiding this comment.
I added .dup here because the modifications to a_host were polluting other tests.
will-in-wi
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that functional tests (
rake test:functional) are failing on master. This PR fixes them with the following commits:I also made a change to
.travis.ymlas an optimization. Normally Travis CI runs builds twice on PRs, once for the push to the branch, and another for the PR itself. This is redundant and causes PRs checks to take longer that necessary. Fix this by restricting "push" builds to the master branch only.No CHANGELOG entry since these are not user-facing changes.